-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Use invalid prop for most inputs #1240
Conversation
# Conflicts: # packages/react/src/TextArea/TextArea.test.tsx # packages/react/src/TextArea/TextArea.tsx # packages/react/src/TextInput/TextInput.test.tsx # packages/react/src/TextInput/TextInput.tsx
Copied this to a change, preventing quoting high-level comments.
Well, there are theoretical situations. Both implement the We offer Switch to toggle UI states only, so it can never become invalid in practice. We can remove all validation fields from the type, or not even use the A Search Field might have a minimum length of e.g. 3 characters to facilitate meaningful results, although I would not expect it to turn red if the field gets blurred with a content of less than 3 characters. On the other hand, if people press Enter or click the Search Button, there should be a way to inform them of this rule. So maybe yes for Search Field, and tighten the props for Switch? |
…into feature/DES-733-use-invalid-prop
…/Amsterdam/design-system into feature/DES-733-use-invalid-prop
Questions:
invalid
prop? Are there situations in which these can be invalid?